Thread (15 messages) 15 messages, 2 authors, 2010-10-26

RE: [PATCH -mm 0/2] RapidIO: Changes to handling of RIO switches

From: Bounine, Alexandre <hidden>
Date: 2010-10-26 13:40:05
Also in: lkml

Micha Nelissen [off-list ref] wrote:
=20
I look at it this way: it prevents the need for another layer of
indirection: translating component tag to a destid.
The destid alone is not enough. You will need an entire rio_dev object
for that device anyway.
=20
Why no relation? My experience is that during debugging it's useful to
have the destid directly at hand, it's just very practical. (Otherwise
any drawing of a random network would need two "identification"
numbers
per drawn node: the component tag (true identification), and destid
since that's what everyone uses to identify a device, what needs to
programmed into the LUTs of a switch, identification in sysfs, etc.).
I think we are mixing two things together here. I understand your idea
but do not see how it prevents me from having one common set of access
coordinates for RIO devices (the starting point of our discussion).=20

Regardless of an implementation, having a way that ensures unified
identification of switches by all processor boards is better than the
current mainline implementation. Methods of forming a component tag may
differ but still serve the same purpose. Personally I prefer to avoid
any link of device identification to the destid because it may not be as
intuitive as it seems for large systems with hot-plug. I will discuss
this with some of RIO TWG guys to get their opinion on the best
approach.

I will make a patch that defines fields of component tag, probably just
one for now - identification field. This will ensure that any method
used to assign component tag (id part of it) will be compatible with RIO
spec part 8 error management.

As for switch identification, at this moment I still prefer replacing
rswitch->switchid with ID portion of the component tag because it is
very simple and does not require changes to enumeration algorithm.  =20

Alex.

          =20
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help