Re: [PATCH v2] pseries: don't override CONFIG_PPC_PSERIES_DEBUG
From: Linas Vepstas <linasvepstas@gmail.com>
Date: 2010-10-15 01:55:08
Also in:
lkml
On 14 October 2010 19:48, Nishanth Aravamudan [off-list ref] wrote:
eeh and pci_dlpar #undef DEBUG, but I think they were added before the ability to control this from Kconfig. It's really annoying to only get some of the debug messages from these files. Leave the lpar.c #undef alone as it produces so much output as to make the kernel unusable. Update the Kconfig text to indicate this particular quirk :) Signed-off-by: Nishanth Aravamudan <redacted>
OK, ignore my last email. Acked by: Linas Vepstas [off-list ref]
quoted hunk ↗ jump to hunk
--- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig@@ -47,6 +47,12 @@ config LPARCFG=C2=A0config PPC_PSERIES_DEBUG =C2=A0 =C2=A0 =C2=A0 =C2=A0depends on PPC_PSERIES && PPC_EARLY_DEBUG =C2=A0 =C2=A0 =C2=A0 =C2=A0bool "Enable extra debug logging in platforms/=
pseries"
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0help + =C2=A0 =C2=A0 =C2=A0 =C2=A0 Say Y here if you want the pseries core to =
produce a bunch of
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 debug messages to the system log. Select th=
is if you are having a
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 problem with the pseries core and want to s=
ee more of what is
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 going on. This does not enable debugging in=
lpar.c, which must
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 be manually done due to its verbosity. =C2=A0 =C2=A0 =C2=A0 =C2=A0default y
Umm, I see "default y" and you are not changing this but ... default y ?? Really? Also, I am guessing that the lpar spam is due only to a handful of printk's= , while most of the rest will be infrequent. Just knock out the high-frequency ones... --linas