Thread (12 messages) 12 messages, 3 authors, 2010-09-15

Re: linux-next: build warnings after merge of the final tree (tip treee related)

From: Stephen Rothwell <hidden>
Date: 2010-09-15 04:39:13
Also in: linux-next, lkml

Hi Yinghai,

On Tue, 14 Sep 2010 18:33:34 -0700 Yinghai Lu [off-list ref] wrote:
On 09/14/2010 05:29 PM, Stephen Rothwell wrote:
quoted
Do not remove the "extern" key word.
why? you got another warning?
It is normal C coding practice to mark declarations in header files with
extern.  It probably doesn't strictly matter for functions, but I have
seen a case where not doing so to a variable lead to multiple definitions
of the variable.  Consistency is also good.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Attachments

  • (unnamed) [application/pgp-signature] 490 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help