On Aug 28, 2010, at 5:34 PM, Timur Tabi wrote:

quoted

[off-list ref] wrote:

=20

quoted

+
+       for_each_node_by_name(np, "global-utilities") {
+               if ((of_get_property(np, "fsl,has-rstcr", NULL))) {
+                       rstcr =3D of_iomap(np, 0) + 0xb0;
+                       if (!rstcr)
+                               printk (KERN_EMERG "Error: reset =

control "

=20
I'm not sure KERN_EMERG is warranted for this kind of error.

I'm not sure either - I left it as it was before.

=20

quoted

+                                               "register not =

mapped!\n");

quoted

+               }

=20
So if a node has an fsl,rstcr property, but the of_iomap() fails, we
jump to the next global-utilities node?  Perhaps you need a 'break'
after the printk()?

Or potentially a continue to be more robust? Or would two (or more) =
"has-rstcr" nodes be wrong?

=20

quoted

+       }
+
+       if (!rstcr && ppc_md.restart =3D=3D fsl_rstcr_restart)

=20
Wouldn't it make more sense to assign fsl_rstcr_restart to
ppc_md.restart only if we find a valid fsl,has-rstcr property?

Again I'm not entirely sure, I left this as it was before. Is there =
another way to reset the board if the rstcr node was not found =
correctly?

-M

=20
--=20
Timur Tabi
Linux kernel developer at Freescale
=20