Re: [PATCH 8/9] arch/powerpc/kernel: Drop unnecessary null test
From: Dan Carpenter <hidden>
Date: 2010-08-03 21:52:08
Also in:
kernel-janitors, linux-devicetree, lkml
On Tue, Aug 03, 2010 at 11:35:17PM +0200, Julia Lawall wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c index 6ddb795..62dd363 100644 --- a/arch/powerpc/kernel/pci_of_scan.c +++ b/arch/powerpc/kernel/pci_of_scan.c@@ -336,8 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node, if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE || dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) { struct device_node *child = pci_device_to_OF_node(dev); - if (dev) - of_scan_pci_bridge(child, dev); + of_scan_pci_bridge(child, dev);
The intention was probably to check "child" instead of "dev". pci_device_to_OF_node() can return NULL. On the other hand the code has been this way for a year and no one has complained... regards, dan carpenter
} } }