Re: [PATCH] Adjust arch/powerpc inline asms for recent gcc change
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2010-07-08 06:08:11
On Fri, 2010-06-25 at 11:56 +0200, Jakub Jelinek wrote:
quoted hunk ↗ jump to hunk
static inline void sync(void)diff --git a/arch/powerpc/include/asm/atomic.h b/arch/powerpc/include/asm/atomic.h index b8f152e..288d8b2 100644 --- a/arch/powerpc/include/asm/atomic.h +++ b/arch/powerpc/include/asm/atomic.h@@ -19,14 +19,14 @@ static __inline__ int atomic_read(const atomic_t *v) { int t; - __asm__ __volatile__("lwz%U1%X1 %0,%1" : "=r"(t) : "m"(v->counter)); + __asm__ __volatile__("lwz%U1%X1 %0,%1" : "=r"(t) : "m<>"(v->counter)); return t; }
This gives me: /home/benh/linux-powerpc-test/arch/powerpc/kernel/time.c: In function ‘timer_interrupt’: /home/benh/linux-powerpc-test/arch/powerpc/include/asm/atomic.h:22: error: ‘asm’ operand has impossible constraints make[2]: *** [arch/powerpc/kernel/time.o] Error 1 $ gcc --version gcc (Debian 4.4.4-1) 4.4.4 Cheers, Ben.