Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

From
Grant Likely <hidden>
Date
2010-07-16 20:37:30
Also in
linux-arm-kernel, linux-kbuild, lkml
Reply to
Nicolas Pitre, 2010-07-16
On Fri, Jul 16, 2010 at 2:29 PM, Nicolas Pitre [off-list ref] wrote:
On Fri, 16 Jul 2010, Grant Likely wrote:
quoted
On Fri, Jul 16, 2010 at 2:09 PM, Catalin Marinas
[off-list ref] wrote:
quoted
On Fri, 2010-07-16 at 19:46 +0100, Linus Torvalds wrote:
quoted
On Fri, Jul 16, 2010 at 11:40 AM, Nicolas Pitre [off-list ref] wr=
ote:
quoted
quoted
quoted
quoted
DOH.
Well, it's possible that the correct approach is a mixture.

Automatically do the trivial cases (recursive selects, dependencies
that are simple or of the form "x && y" etc), and warn about the case=
s
quoted
quoted
quoted
that aren't trivial (where "not trivial" may not necessarily be about
fundamentally ambiguous ones, but just "complex enough that I won't
even try").
There is still a risk with this approach when the Kconfig isn't entire=
ly
quoted
quoted
correct. For example, on ARM we have (I pushed a patch already):

config CPU_32v6K
=A0 =A0 =A0 =A0depends on CPU_V6

config CPU_V7
=A0 =A0 =A0 =A0select CPU_32v6K

In this simple approach, we end up selecting CPU_V6 when we only need
CPU_V7. There other places like this in the kernel.

Of course, kbuild could still warn but if people rely on this feature =
to
quoted
quoted
select options automatically I suspect they would ignore the warnings.
In my first patch, I made Kconfig problems errors instead of warnings.
=A0That would prevent people from ignoring them.
ACK.
It would also flush out any current Kconfig dependency issues.

g.
Thread (28 messages) 28 messages, 8 authors, last reply 2010-07-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help