Thread (78 messages) 78 messages, 6 authors, 2010-06-29

Re: [PATCH 18/26] KVM: PPC: KVM PV guest stubs

From: Alexander Graf <hidden>
Date: 2010-06-28 08:23:13
Also in: kvm

On 28.06.2010, at 10:15, Avi Kivity wrote:
On 06/28/2010 09:33 AM, Alexander Graf wrote:
quoted
=20
quoted
Could you do something similar in module_finalize() to patch loaded =
modules' .text sections?
quoted
quoted
   =20
I could, but do we need it? I objdump -d | grep'ed all my modules and =
didn't find any need to do so.
quoted
 =20
=20
You mean even kvm.ko doesn't use privileged instructions?
It does, but I don't think it's worth speeding those up. There are only =
a couple. Most of the privileged instructions in PPC KVM are statically =
compiled into the kernel because we need to guarantee they're in the RMO =
(first 8MB for the PS3).

Even with the magic page in use, trapping instructions still works =
exactly as before, so we're only talking about a speed difference.


Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help