Re: [PATCH 3/3] fsl_rio: fix non-standard HID1 register access
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2010-06-18 05:46:21
On Fri, Jun 18, 2010 at 07:29, Li Yang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The access to HID1 register is only legitimate for e500 v1/v2 cores. Signed-off-by: Li Yang <redacted> --- =C2=A0arch/powerpc/sysdev/fsl_rio.c | =C2=A0 =C2=A07 +++++-- =C2=A01 files changed, 5 insertions(+), 2 deletions(-)diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.=
c
quoted hunk ↗ jump to hunk
index 954a754..785a882 100644--- a/arch/powerpc/sysdev/fsl_rio.c +++ b/arch/powerpc/sysdev/fsl_rio.c@@ -1523,9 +1523,12 @@ int fsl_rio_setup(struct of_device *dev)=C2=A0#ifdef CONFIG_E500 =C2=A0 =C2=A0 =C2=A0 =C2=A0saved_mcheck_exception =3D ppc_md.machine_chec=
k_exception;
=C2=A0 =C2=A0 =C2=A0 =C2=A0ppc_md.machine_check_exception =3D fsl_rio_mch=
eck_exception;
-#endif - =C2=A0 =C2=A0 =C2=A0 /* Ensure that RFXE is set */ + +#ifndef CONFIG_E500MC + =C2=A0 =C2=A0 =C2=A0 /* Ensure that RFXE is set on e500 v1/v2 */ =C2=A0 =C2=A0 =C2=A0 =C2=A0mtspr(SPRN_HID1, (mfspr(SPRN_HID1) | 0x20000))=
;
+#endif /* !E500MC */ +#endif /* E500 */ =C2=A0 =C2=A0 =C2=A0 =C2=A0return 0; =C2=A0err:
This prevents you from building a kernel for both normal E500 and E500MC.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org
In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
-- Linus Torvalds