On Mit, 2010-06-02 at 15:33 +1000, Paul Mackerras wrote:=20
This fixes a sporadic oops at boot on G5 Power Macs. The table_end
variable has the address of the last byte of the table. Adding on
PAGE_SIZE means we flush too much, and if the page after the table
is not mapped for any reason, the kernel will oops. Instead we add
on 1 because flush_dcache_range() interprets its second argument as
the first byte past the range to be flushed.
=20
Signed-off-by: Paul Mackerras <redacted>
Reviewed-by: Michel D=C3=A4nzer <redacted>
Tested-by: Michel D=C3=A4nzer <redacted>
Thanks for the good catch, Paul.
quoted hunk ↗ jump to hunk
---
=20
diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-=
agp.c
quoted hunk ↗ jump to hunk
index 6f48931..9aaa0eb 100644
--- a/drivers/char/agp/uninorth-agp.c
+++ b/drivers/char/agp/uninorth-agp.c
@@ -413,7 +413,7 @@ static int uninorth_create_gatt_table(struct agp_brid=
ge_data *bridge)
quoted hunk ↗ jump to hunk
bridge->gatt_table_real =3D (u32 *) table;
/* Need to clear out any dirty data still sitting in caches */
flush_dcache_range((unsigned long)table,
- (unsigned long)(table_end + PAGE_SIZE));
+ (unsigned long)table_end + 1);
bridge->gatt_table =3D vmap(pages, (1 << page_order), 0, PAGE_KERNEL_NC=
G);
=20
if (bridge->gatt_table =3D=3D NULL)
--=20
Earthling Michel D=C3=A4nzer | http://www.vmware.c=
om
Libre software enthusiast | Debian, X and DRI developer