Thread (7 messages) 7 messages, 4 authors, 2010-06-02

Re: [PATCH] KVM: PPC: elide struct thread_struct instances from stack

From: Alexander Graf <hidden>
Date: 2010-06-01 09:19:31
Also in: kvm

On 01.06.2010, at 10:36, Andreas Schwab wrote:
Paul Mackerras [off-list ref] writes:
=20
quoted
I re-read the relevant part of the PowerPC architecture spec
yesterday, and it seems pretty clear that the FPSCR doesn't affect =
the
quoted
behaviour of lfs and stfs, and is not affected by them.  So in fact 4
out of the 7 instructions in each of those procedures are unnecessary
(and similarly for the cvt_fd/df used in the alignment fixup code).
=20
I'd prefer to have this deferred to a separate patch.
I agree. Andreas' patch takes the current logic and moves it to be KVM =
contained, so we don't clutter the stack. The fact that the old code was =
inefficient is a separate story.

Avi / Marcelo, please apply the patch nevertheless.


Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help