On Thu, Jun 10, 2010 at 12:38 AM, Benjamin Herrenschmidt
[off-list ref] wrote:

On Fri, 2010-06-04 at 15:21 -0600, Grant Likely wrote:

quoted

Merge common code between PowerPC and Microblaze. =A0Also create a new
arch hook, of_irq_find_parent_by_phandle() to handle arch-specific
quirks.

First, you changeset comment should be much more verbose as to
what that arch specific quirk is about etc... it took me time to figure
it out again :-)

I dislike the naming you use. Your "of_irq_find_parent_by_phandle"
doesn't ring "right" to me.

I'm tempted to say we should put the quirks in the common code, your
attempt at "abstracting" them just makes the code much harder to follow.

Also, if we stick to your approach the "default" variant should either
be an inline protected by an ifndef or a weak function.

Alright, I've rewritten all the IRQ changes and I've left the quirk
handling in common code, while moving the powermac quirk code into
arch/powerpc/platforms/powermac.  I'll repost today.

g.