On Fri, May 28, 2010 at 02:23:30PM +1000, Michael Neuling wrote:

In message [ref] you wrote:

quoted

On Fri, May 28, 2010 at 12:28:43PM +1000, Michael Neuling wrote:

quoted

In message [ref] you wrote:

quoted

Hi Paul,

While we are at it, can we also add nop to the list of emulated
instructions?

Ananth
---
From: Ananth N Mavinakayanahalli <redacted>

Emulate ori 0,0,0 (nop).

The long winded way is to do:

        case 24:
                rd = (instr >> 21) & 0x1f;
                if (rd != 0)
                        break;
                rb = (instr >> 11) & 0x1f;
                if (rb != 0)
                        break;

Don't we just need rb == rd?

Sure. But for this case, just checking against the opcode seems simple
enough.

Simple, sure.  You could not emulate anything and remove the code
altogether.  That would be truly simple. :-P

Ah.. I misunderstood your initial point about rb == rd with imm = 0.

Why not eliminate as much as possible?

Anyway, sounds like paulus as a better solution.

Right.

Ananth