Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)
From: Michael Ellerman <hidden>
Date: 2010-05-20 01:34:12
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 198 bytes
From: Michael Ellerman <hidden>
Date: 2010-05-20 01:34:12
Also in:
lkml
On Wed, 2010-05-19 at 23:08 +0200, Thomas Gleixner wrote:
On Wed, 19 May 2010, Thomas Gleixner wrote:quoted
quoted
I'm still not clear on why the ultimate solution wasn't to have XICS report edge triggered as edge triggered. Probably some complexity of the entire power stack that I am ignorant of.quoted
Apart from the issue of loosing interrupts there is also the fact that masking on the XICS requires an RTAS call which takes a global lock.Right, I'd love to avoid that but with real level interrupts we'd run into an interrupt storm. Though another solution would be to issue the EOI after the threaded handler finished, that'd work as well, but needs testing.Thought more about that. The case at hand (ehea) is nasty: The driver does _NOT_ disable the rx interrupt in the card in the rx interrupt handler - for whatever reason.
Yeah I saw that, but I don't know why it's written that way. Perhaps Jan-Bernd or Doug will chime in and enlighten us? :) cheers