Re: [PATCH 3/4] fsl_msi: enable msi sharing through AMP OSes
From: Michael Ellerman <hidden>
Date: 2010-04-19 02:34:09
On Fri, 2010-04-16 at 15:34 +0800, Li Yang wrote:
From: Zhao Chenhui <redacted> Make a single PCIe MSI bank shareable through CAMP OSes. The number of MSI used by each core can be configured by dts file. Signed-off-by: Zhao Chenhui <redacted> Signed-off-by: Li Yang <redacted> --- arch/powerpc/sysdev/fsl_msi.c | 8 +++++++- arch/powerpc/sysdev/msi_bitmap.c | 4 ++-- 2 files changed, 9 insertions(+), 3 deletions(-)
..
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/sysdev/msi_bitmap.c b/arch/powerpc/sysdev/msi_bitmap.c index 5a32cbe..b41db96 100644 --- a/arch/powerpc/sysdev/msi_bitmap.c +++ b/arch/powerpc/sysdev/msi_bitmap.c@@ -95,8 +95,8 @@ int msi_bitmap_reserve_dt_hwirqs(struct msi_bitmap *bmp) /* Format is: (<u32 start> <u32 count>)+ */ len /= 2 * sizeof(u32); for (i = 0; i < len; i++, p += 2) { - for (j = 0; j < *(p + 1); j++) - bitmap_release_region(bmp->bitmap, *p + j, 0); + for (j = *p; j < *(p + 1); j++) + bitmap_release_region(bmp->bitmap, j, 0); } spin_unlock(&bmp->lock);
This looks like a bug fix to the msi bitmap code, is it not? Please split it into a separate commit with an explanatory changelog. cheers
Attachments
- signature.asc [application/pgp-signature] 197 bytes