Thread (5 messages) 5 messages, 2 authors, 2010-05-01

Re: -next Apr 30: OOPS during eHEA driver initialization

From: Grant Likely <hidden>
Date: 2010-04-30 17:44:13
Also in: linux-next, lkml
Subsystem: linux for powerpc (32-bit and 64-bit), the rest · Maintainers: Madhavan Srinivasan, Michael Ellerman, Linus Torvalds

On Fri, Apr 30, 2010 at 11:35 AM, Grant Likely
[off-list ref] wrote:
On Fri, Apr 30, 2010 at 11:27 AM, Sachin Sant [off-list ref] wrote:
quoted
Sachin Sant wrote:
quoted
With today's next eHEA drivers fails to initialize.
If i revert the following patch eHEA network interface is initialized
properly.

commit cebfe0b6709abdab997c1a00499d67efa32ee1f0
drivercore: Add of_match_table to the common device drivers
That is an easy one to fix. =A0I'll get it updated today and send you the=
 result.

Let me know if this patch fixes it:

Cheers,
g.
diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index ce957a4..693b0e6 100644
--- a/arch/powerpc/kernel/ibmebus.c
+++ b/arch/powerpc/kernel/ibmebus.c
@@ -201,6 +201,9 @@ static int ibmebus_create_devices(const struct
of_device_id *matches)

 int ibmebus_register_driver(struct of_platform_driver *drv)
 {
+	if (!drv->driver.of_match_table)
+		drv->driver.of_match_table =3D drv->match_table;
+
 	/* If the driver uses devices that ibmebus doesn't know, add them */
 	ibmebus_create_devices(drv->driver.of_match_table);



--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help