On Thu, Mar 18, 2010 at 9:53 AM, Kumar Gala [off-list ref] wro=
te:

+ =A0 =A0 =A0 /* The multiple setting ppc_md.setup_msi_irqs will not harm=

 things */

+ =A0 =A0 =A0 if (!ppc_md.setup_msi_irqs) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 ppc_md.setup_msi_irqs =3D fsl_setup_msi_irq=

s;

+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 ppc_md.teardown_msi_irqs =3D fsl_teardown_m=

si_irqs;

+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 ppc_md.msi_check_device =3D fsl_msi_check_d=

evice;

+ =A0 =A0 =A0 } else if (ppc_md.setup_msi_irqs !=3D fsl_setup_msi_irqs) {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 dev_err(&dev->dev, "Different MSI driver al=

ready installed!\n");

+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 err =3D -EBUSY; /* or some other error code=

 */

The comment is inappropriate.  I put it there as a reminder that maybe
EBUSY is not the best choice.  But if it is, then the comment should
be removed.

--=20
Timur Tabi
Linux kernel developer at Freescale