Hi Wolfram,

On Wed, 10 Feb 2010 00:24:06 +0100
Wolfram Sang [off-list ref] wrote:

Two comments:

...

quoted

+void mpc512x_restart(char *cmd)
+{
+	struct mpc512x_reset_module *rm = reset_module_base;

Why not using reset_module_base directly?

I will fix it in v4 patch.

quoted

@@ -62,4 +95,5 @@ void __init mpc512x_init(void)
 {
 	mpc512x_declare_of_platform_devices();
 	mpc5121_clk_init();
+	mpc512x_restart_init();

If the return value is not checked here, you could as well make the function
void. (Not much one could do in the error-case, too.)

Will fix it too, thanks!

Anatolij