Re: [PATCH 1/4] Add ps3_storage module alias
From: Geert Uytterhoeven <hidden>
Date: 2010-02-05 14:57:07
On Fri, 5 Feb 2010, Josh Boyer wrote:
On Fri, Feb 05, 2010 at 02:49:14PM +0100, Geert Uytterhoeven wrote:quoted
On Fri, 5 Feb 2010, Josh Boyer wrote:quoted
This allows the upgrade path from older kernel releases to work with the Fedora mkinitrd tool. =20 --- =20--- linux-2.6.22.ppc64/drivers/block/ps3disk.c~=092007-07-25 16:06:16.=
000000000 +0100
quoted
quoted
+++ linux-2.6.22.ppc64/drivers/block/ps3disk.c=092007-07-26 08:49:44.0=
00000000 +0100
quoted
quoted
@@ -628,3 +628,4 @@ MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("PS3 Disk Storage Driver"); MODULE_AUTHOR("Sony Corporation"); MODULE_ALIAS(PS3_MODULE_ALIAS_STOR_DISK); +MODULE_ALIAS("ps3_storage");NAKed-by: Geert Uytterhoeven [off-list ref] ps3_storage was replaced by 3 drivers: ps3disk, ps3rom, and ps3flash. Th=
ese are
quoted
automatically loaded by udev. How does mkinitrd determine the driver for the root file system on other systems? Does it really contain a big list of e.g. all SCSI drivers?=20 At one time I believe it did have a list of "odd" drivers to explicitly include. Anaconda didn't (doesn't?) use udev to determine which drivers to include in the initrd since the install image is most likely not compo=
sed
on a machine that includes those drivers. If the install initrd didn't h=
ave
the drivers loaded, it wouldn't install on PS3. =20 This is highlighted as a Fedora local change, probably for the reasons yo=
u
state. We might have already moved past the point where this is needed, so I'm fine with it being NAKed. I'll probably just drop it from the Fed=
ora
kernel builds.
It's possible it's (still) needed on Fedora, though (Geoff, do you know?). But it's definitely not something we want in mainline. With kind regards, Geert Uytterhoeven Software Architect Techsoft Centre Technology and Software Centre Europe The Corporate Village =B7 Da Vincilaan 7-D1 =B7 B-1935 Zaventem =B7 Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 =B7 RPR Brussels Fortis =B7 BIC GEBABEBB =B7 IBAN BE41293037680010