-----Original Message-----
From: Anton Vorontsov [mailto:avorontsov@ru.mvista.com]=20
Sent: Friday, February 26, 2010 8:45 AM
To: Paul Gortmaker
Cc: Martyn Welch; linuxppc-dev list; netdev@vger.kernel.org;=20
linux-kernel@vger.kernel.org; Kumar Gopalpet-B05799;=20
davem@davemloft.net; Kumar Gala
Subject: Re: Gianfar driver failing on MPC8641D based board

On Thu, Feb 25, 2010 at 07:53:30PM -0500, Paul Gortmaker wrote:
[...]

quoted

I was able to reproduce it on an 8641D and bisected it down to this:
=20
-----------
commit a3bc1f11e9b867a4f49505ecac486a33af248b2e
Author: Anton Vorontsov [off-list ref]
Date:   Tue Nov 10 14:11:10 2009 +0000
=20
    gianfar: Revive SKB recycling

Thanks for the bisect. I have a guess why tx hangs in SMP=20
case. Could anyone try the patch down below?

[...]

quoted

...which probably explains why you weren't seeing it on non-SMP.
I'd imagine it would show up on any of the e500mc boards too.

Yeah.. Pity, I don't have SMP boards anymore. I'll try to get=20
one though.

diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c=20
index 8bd3c9f..3ff3bd0 100644
--- a/drivers/net/gianfar.c
+++ b/drivers/net/gianfar.c

@@ -2614,6 +2614,8 @@ static int gfar_poll(struct napi_struct=20

*napi, int budget)
			tx_queue =3D priv->tx_queue[rx_queue->qindex];
=20
			tx_cleaned +=3D gfar_clean_tx_ring(tx_queue);
+			if (!tx_cleaned && !tx_queue->num_txbdfree)
+				tx_cleaned +=3D 1; /* don't=20
complete napi */
			rx_cleaned_per_queue =3D=20
gfar_clean_rx_ring(rx_queue,
						=09
budget_per_queue);
			rx_cleaned +=3D rx_cleaned_per_queue;