Re: [PATCH 3/8 v2] mtd: Add MPC5121 NAND Flash Controller driver
From: Wolfgang Denk <hidden>
Date: 2010-01-27 20:24:32
From: Wolfgang Denk <hidden>
Date: 2010-01-27 20:24:32
Dear Grant Likely, In message [ref] you wrote:
quoted
+ if (rev != 2) { + dev_err(dev, "SoC revision %u is not supported!\n", rev); + return -ENXIO; + }*Only* revision 2? Are future revisions of silicon assumed to be broken then?
I vote for keeping it this way - if you look at the diffferences between revision 1 and 2, or at differences between MPC5121/3 and MPC5125, it is more than likely that revision 3, should it ever come out, will be incompatible and require driver changes. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Landru! Guide us! -- A Beta 3-oid, "The Return of the Archons", stardate 3157.4