Re: [PATCH 1/2] powerpc/44x: Add MTD support (NOR FLASH) to Katmai dts
From: Josh Boyer <hidden>
Date: 2010-01-26 15:04:19
On Tue, Jan 26, 2010 at 02:50:07PM +0100, Stefan Roese wrote:
quoted hunk ↗ jump to hunk
This patch adds NOR FLASH MTD support to the Katmai (440SPe) dts file. Additionally with a small whitespace cleanup. Signed-off-by: Stefan Roese <sr@denx.de> Cc: Josh Boyer <redacted> --- arch/powerpc/boot/dts/katmai.dts | 71 +++++++++++++++++++++++++++---------- 1 files changed, 52 insertions(+), 19 deletions(-)diff --git a/arch/powerpc/boot/dts/katmai.dts b/arch/powerpc/boot/dts/katmai.dts index 8f345de..8cf2c0c 100644 --- a/arch/powerpc/boot/dts/katmai.dts +++ b/arch/powerpc/boot/dts/katmai.dts@@ -156,7 +156,7 @@compatible = "ibm,opb-440spe", "ibm,opb-440gp", "ibm,opb"; #address-cells = <1>; #size-cells = <1>; - ranges = <0x00000000 0x00000004 0xe0000000 0x20000000>; + ranges = <0xe0000000 0x00000004 0xe0000000 0x20000000>;
Could you explain why this was needed? It seems to shift the addresses of all the rest of the devices under the OPB.
quoted hunk ↗ jump to hunk
clock-frequency = <0>; /* Filled in by zImage */ EBC0: ebc {@@ -165,14 +165,47 @@#address-cells = <2>; #size-cells = <1>; clock-frequency = <0>; /* Filled in by zImage */ + /* ranges property is supplied by U-Boot */
That's probably true for newer U-Boot versions, but Katmai shipped with an old version of U-Boot that wasn't FDT-aware. Wouldn't this break a new kernel on the older boards that don't have an updated U-Boot since the ranges property will be missing entirely there? josh