Thread (33 messages) 33 messages, 5 authors, 2010-01-04

Re: [PATCH v2 2/3] powerpc: Add support for creating FIT uImages

From: Grant Likely <hidden>
Date: 2010-01-03 05:24:10
Also in: linux-kbuild

On Fri, Jan 1, 2010 at 7:18 AM, Wolfgang Denk [off-list ref] wrote:
quoted
Rather than adding new paths to arch/powerpc/boot/wrapper, I would
rather see a new script used for generating FIT image that isn't
complicated by all the current wrapper cruft. =A0Also, the Makefile rule
doesn't need to depend on $(wrapperbits) which means faster build
times when only building uImages.

Bonus points if you also convert the uImage target to use the new
script; but I'm not demanding that you do that yet.
I think if this is handles in a separate script, the legacy uImage
support must be handled in this new script, too. Otherwise it would be
too difficult to understanmd the relation of the two image formats.
I'm fine with this.  But if I receive a patch that does one and not
the other, I'll probably still merge it.  :-)
quoted
Finally, you need to add documentation about the new target to
Documentation/powerpc/bootwrapper.txt.
Let's keep in mind that the uImage formats (both the old legacy and
the new FIT format) are inherently architecture independent. We want
to use this same mechanism for example on ARM, and on other
architectures as well.
That's fine, but Documentation/powerpc/bootwrapper.txt happens to also
be the place that documents how the boot image creation on
arch/powerpc works.  I'm happy for the text about uImage and fitImage
to make reference to a different Documentation file or URL.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help