Re: i2c_powermac: Kernel access of bad area
From: Christian Kujau <hidden>
Date: 2010-01-06 19:14:36
Also in:
lkml
On Wed, 6 Jan 2010 at 17:37, Jean Delvare wrote:
Christian, did you happen to try removing the i2c-powermac driver before?
Well, I definitely removed the driver before, but I'm not sure if I ever read the /sys files after doing this :-\
I am curious if this is a recent problem, possibly caused by changes to the i2c stack, or if older kernels already had this problem and nobody ever noticed. I suspect the latter.
Fair question, but I really could't tell. I realize a bisection would be helpful, but I don't think I'll have to time to do this on this machine (it's a PowerBook G4, but kernel still compilation usually takes ~30min) and I'm not sure that I care _that_ much about this particular issue. I just wanted to report this one, for the sake of the archives, as noone else seems to be bothered by it anyway...
I think that sysfs files creation should be moved to the end of probe_thermostat() and sysfs files removal should be moved to the beginning of remove_thermostat(). Something like the totally untested patch below (no ppc machine at hand):
OK, thanks Jean - I'll give it a try later today and let you know. Thanks again, Christian. -- BOFH excuse #398: Data for intranet got routed through the extranet and landed on the internet.