Thread (27 messages) 27 messages, 3 authors, 2009-12-02

Re: [RFC PATCH v2 09/11] powerpc: gamecube/wii: flipper interrupt controller support

From: Albert Herranz <hidden>
Date: 2009-12-02 23:29:39

Benjamin Herrenschmidt wrote:
On Tue, 2009-12-01 at 20:48 +0100, Albert Herranz wrote:
quoted
This -1 should be NO_IRQ too.
I'll fix this in the next version.
No. The number you pass here is not a linux virq number, but a number in
your HW numbering space that never represents a valid IRQ. In your case
0 (NO_IRQ is deprecated anyways) is a valid HW interrupt number. However
-1 sounds good.

So your existing code is fine.
Oh. Good to know.
Then I need to fix the other PIC driver :)
Cheers,
Ben.
Thanks,
Albert
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help