Thread (5 messages) 5 messages, 2 authors, 2009-12-01

Re: [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop()

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2009-12-01 07:57:51
Also in: linux-ide

On Tue, 2009-12-01 at 16:33 +0900, Tejun Heo wrote:
quoted
Feel free to pick that one up earlier if you want (ie for 2.6.32),
as
quoted
long as we manage to get it in in 2.6.33 -before- I push
powerpc-next to
quoted
Linus, I'm happy :-) (or we can have it in both trees).
As nasty as the bug might be, given that we haven't had too much
problem with that, I think it would be best to give it some time to be
tested before releasing it to users.  It causes behavior differences
for all bmdma drivers which implement custom bmdma_stop.  It's an
apparent bug fix but well the nasty ones are always apparent bug
fixes, right?  :-) 
Yeah, I agree. I wouldn't be comfortable pushing it into .32 to be
honest after a quick grep of how many drivers actually use that hook and
considering that no problem was reported so far...

I'll merge it with the rest of the powerpc stuff during the .33 merge
window if you are ok with that.

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help