Thread (5 messages) 5 messages, 3 authors, 2009-11-30

Re: [PATCH] powerpc: Fix DEBUG_HIGHMEM build break from d4515646699

From: Josh Boyer <hidden>
Date: 2009-11-30 19:54:43

On Tue, Dec 01, 2009 at 06:49:43AM +1100, Benjamin Herrenschmidt wrote:
On Mon, 2009-11-30 at 12:57 -0500, Josh Boyer wrote:
quoted
On Mon, Nov 23, 2009 at 04:28:53PM -0600, Becky Bruce wrote:
quoted
Code was added to mm/higmem.c that depends on several
kmap types that powerpc does not support.  We add dummy
invalid definitions for KM_NMI, KM_NM_PTE, and KM_IRQ_PTE.

According to list discussion, this fix should not be needed
anymore starting with 2.6.33.  The code is commented to this
effect so hopefully we will remember to remove this.

Signed-off-by: Becky Bruce <redacted>
Ben, I see you have this queued up in you 'next' branch, but this seems to be
impacting 2.6.32 and according to the comments won't be needed in 2.6.33.
Right now, 2.6.32 doesn't build for a general Fedora ppc32 kernel because of
this bug.  Should this be sent to Linus for .32?
Why would fedora have DEBUG_HIGHMEM enabled ? I'll see what I can do.
Why shouldn't it?  Fedora generally builds rawhide kernels with all kinds of
debug options set.

When you say you'll see what you can do, do you mean you'll see if you can get
the patch into .32, or change the Fedora config?  If you mean change the Fedora
config, I can do that myself.  I was more pointing out that you have a .32
patch not needed for .33 heading for .33... ;)

josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help