RE: [spi-devel-general] [PATCH v4] xilinx_spi: Splitted into generic, of and platform driver, added support for DS570

-----Original Message-----
From: linuxppc-dev-bounces+stephen=3Dneuendorffer.name@lists.ozlabs.org [=

mailto:linuxppc-dev-

bounces+stephen=3Dneuendorffer.name@lists.ozlabs.org] On Behalf Of Grant =

Likely

Sent: Monday, November 09, 2009 1:22 PM
To: Richard R=F6jfors
Cc: spi-devel-general@lists.sourceforge.net; Andrew Morton; dbrownell@use=

rs.sourceforge.net; John

Linn; linuxppc-dev@ozlabs.org
Subject: Re: [spi-devel-general] [PATCH v4] xilinx_spi: Splitted into gen=

eric, of and platform

driver, added support for DS570
=

Oops, I replied to the original version, but missed the subsequent
versions.  Looks like some of my comments still apply though.
Overall, the patch changes too many things all at once.  You should
look at splitting it up.  At the very least the io accessor changes
should be done in a separate patch.
=

On Mon, Sep 28, 2009 at 7:22 AM, Richard R=F6jfors
[off-list ref] wrote:

quoted

@@ -227,6 +227,21 @@ config SPI_XILINX

=A0 =A0 =A0 =A0 =A0See the "OPB Serial Peripheral Interface (SPI) (v1.0=

0e)"

quoted

=A0 =A0 =A0 =A0 =A0Product Specification document (DS464) for hardware =

details.

quoted

+ =A0 =A0 =A0 =A0 Or for the DS570, see "XPS Serial Peripheral Interfac=

e (SPI) (v2.00b)"

quoted

+
+config SPI_XILINX_OF
+ =A0 =A0 =A0 tristate "Xilinx SPI controller OF device"
+ =A0 =A0 =A0 depends on SPI_XILINX && XILINX_VIRTEX
+ =A0 =A0 =A0 help
+ =A0 =A0 =A0 =A0 This is the OF driver for the SPI controller IP from =

the Xilinx EDK.

quoted

+
+config SPI_XILINX_PLTFM
+ =A0 =A0 =A0 tristate "Xilinx SPI controller platform device"
+ =A0 =A0 =A0 depends on SPI_XILINX
+ =A0 =A0 =A0 help
+ =A0 =A0 =A0 =A0 This is the platform driver for the SPI controller IP=

quoted

+ =A0 =A0 =A0 =A0 from the Xilinx EDK.
+

=

Personally, I don't think it is necessary to present these options to
the user.  I think they can be auto-selected depending on CONFIG_OF
and CONFIG_PLATFORM.

And in any event, OF should work for MICROBLAZE, too...

Steve
 =


This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.