Thread (4 messages) 4 messages, 3 authors, 2009-11-25

Re: [PATCH v2 11/11] of: unify phandle name in struct device_node

From: Segher Boessenkool <hidden>
Date: 2009-11-25 01:30:45
Also in: linux-devicetree, sparclinux

In struct device_node, the phandle is named 'linux_phandle' for  
PowerPC
and MicroBlaze, and 'node' for SPARC.  There is no good reason for the
difference, it is just an artifact of the code diverging over a couple
of years.  This patch renames both to simply .phandle.

Note: the .node also existed in PowerPC/MicroBlaze, but the only user
seems to be arch/powerpc/platforms/powermac/pfunc_core.c.  It doesn't
look like the assignment between .linux_phandle and .node is
significantly different enough to warrant the separate code paths
unless ibm,phandle properties actually appear in Apple device trees.

I think it is safe to eliminate the old .node property and use
linux_phandle everywhere.
   ^^^^^^^^^^^^  You forgot to update one :-)

Segher
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help