Re: [PATCH 0/4] powerpc: Fix minor build issues on 2.6.32-rc7 without CONFIG_XICS set
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2009-11-27 02:40:57
Also in:
lkml
On Wed, 2009-11-18 at 17:05 +0000, Mel Gorman wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig index 04a8061..a82c470 100644 --- a/arch/powerpc/platforms/Kconfig +++ b/arch/powerpc/platforms/Kconfig@@ -52,9 +52,9 @@ config PPC_UDBG_BEAT default n config XICS - depends on PPC_PSERIES + depends on PCI_MSI bool - default y + default n
Why the above ? XICS only exist on PSERIES and select bypass depends in nasty ways anyways.
quoted hunk ↗ jump to hunk
config IPIC booldiff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index f0e6f28..81c2289 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig@@ -5,6 +5,8 @@ config PPC_PSERIES select PPC_I8259 select PPC_RTAS select RTAS_ERROR_LOGGING + select PCI_MSI + select XICS select PPC_UDBG_16550 select PPC_NATIVE select PPC_PCI_CHOICE if EMBEDDED
The above bits look plenty enough. Can you also stick it next to the MPIC one ? Cheers, Ben.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/