Thread (8 messages) 8 messages, 3 authors, 2009-11-10

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

From: Stephen Rothwell <hidden>
Date: 2009-10-31 05:33:07
Also in: linux-spi

Hi Wolfram,

On Fri, 30 Oct 2009 20:44:12 +0100 Wolfram Sang [off-list ref] wrote:
 static struct of_platform_driver mpc52xx_psc_spi_of_driver = {
 	.owner = THIS_MODULE,
-	.name = "mpc52xx-psc-spi",
+	.name = DRIVER_NAME,
You no longer need to set either owner or name in the of_platform driver,
just in the included struct driver (as is done below), so you could just
remove the above two lines.
 	.match_table = mpc52xx_psc_spi_of_match,
 	.probe = mpc52xx_psc_spi_of_probe,
 	.remove = __exit_p(mpc52xx_psc_spi_of_remove),
 	.driver = {
-		.name = "mpc52xx-psc-spi",
+		.name = DRIVER_NAME,
 		.owner = THIS_MODULE,
 	},
 };
I am hoping that we can remove the owner and name fields from struct
of_platform_driver sometime.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Attachments

  • (unnamed) [application/pgp-signature] 198 bytes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help