RE: [PATCH] USB: Add support for Xilinx USB host controller

Thanks, Grant and Ben,

quoted

Add bus glue driver for Xilinx USB host controller. The controller can

be

quoted

configured as HS only or HS/FS hybrid. The driver uses the device tree

file

quoted

to configure the driver according to the setting in the hardware system=

.

quoted

This driver has been tested with usbtest using the NET2280 PCI card.

Signed-off-by: Julie Zhu <redacted>

=

As Ben said, this is nice tight code.  Two comments below.
=

quoted

+/**
+ * ehci_xilinx_port_handed_over - hand the port out if failed to enabl=

e

it

quoted

+ * @hcd: =A0 =A0 =A0 Pointer to the usb_hcd device to which the host

controller bound

quoted

+ * @portnum:Port number to which the device is attached.
+ *
+ * This function is used as a place to tell the user that the Xilinx

USB host

quoted

+ * controller does support LS devices. And in an HS only configuration=

,

it

quoted

+ * does not support FS devices neither. It is hoped that this can help=

a
=

s/neither/either
=

[...]

quoted

+static struct of_device_id ehci_hcd_xilinx_of_match[] =3D {
+ =A0 =A0 =A0 {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 .compatible =3D "usb-ehci",
+ =A0 =A0 =A0 },

=

This looks wrong.  Since this driver only works with Xilinx USB
controllers,
it should be binding against "xlnx,xps-usb-host-1.00.a", and the meaning
of
that binding needs to be documented in Documentation/powerpc/dts-bindings=

.

=

I have changed the compatible to "xlnx,xps-usb-host-1.00.a", thanks for cat=
ching this.

Where should I put the binding for Xilinx USB host controller? usb-ehci.txt=
 or xilinx.txt?

Thanks,
Julie.

Having this driver bind against the generic "usb-ehci" will cause
conflicts
with the ehci-ppc-of driver.
=

Cheers,
g.
=

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.