Thread (7 messages) 7 messages, 4 authors, 2009-08-25

Re: [PATCH v2] qe_lib: Set gpio data before changing the direction to output

From: Kumar Gala <hidden>
Date: 2009-08-25 14:45:08

On Aug 18, 2009, at 4:20 PM, Michael Barkowski wrote:
This avoids having a short glitch if the desired initial value is not
the same as what was previously in the data register.

Signed-off-by: Michael Barkowski <redacted>
---
Anton Vorontsov wrote:
quoted
There is a recursive locking bug: _set() takes the same spinlock.
So you'd better move this call two lines upper. Otherwise the
patch looks OK.

Thanks!
Thanks - here is v2.

arch/powerpc/sysdev/qe_lib/gpio.c |    4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

applied to next.

- k
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help