Re: lmb: Remove __init from lmb_end_of_DRAM()

From
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date
2009-08-28 07:21:43
Also in
lkml
On Thu, 2009-08-27 at 19:59 +0000, Linux Kernel Mailing List wrote:
Gitweb:     http://git.kernel.org/linus/4f8ee2c9cc0e885d2bb50ef26db66150ab25213e
Commit:     4f8ee2c9cc0e885d2bb50ef26db66150ab25213e
Parent:     cf481442f2e086316ed8a1b3046f00ad23632ac4
Author:     Benjamin Herrenschmidt [off-list ref]
AuthorDate: Thu Aug 27 17:20:30 2009 +1000
Committer:  Linus Torvalds [off-list ref]
CommitDate: Thu Aug 27 12:25:26 2009 -0700

    lmb: Remove __init from lmb_end_of_DRAM()
    
    We call lmb_end_of_DRAM() to test whether a DMA mask is ok on a machine
    without IOMMU, but this function is marked as __init.
    
    I don't think there's a clean way to get the top of RAM max_pfn doesn't
    appear to include highmem or I missed (or we have a bug :-) so for now,
    let's just avoid having a broken 2.6.31 by making this function
    non-__init and we can revisit later.
And another brown paper bag for me ! Patch is fine, but doesn't do the
job because some idiot (me) didn't actually test (it looked so obvious)
and didn't notice somebody had the strange idea to also put __init on
the declaration in the .h file ! Ugh.

I'll send another patch later, have to run home now.

Cheers,
Ben.
Thread (1 message) 1 message, 1 author, 2009-08-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help