Thread (8 messages) 8 messages, 7 authors, 2009-08-27

Re: spin_is_locked() broken for uniprocessor?

From: Alan Cox <hidden>
Date: 2009-08-19 10:52:47
Also in: lkml

On Wed, 19 Aug 2009 10:38:06 +0100
David Howells [off-list ref] wrote:
Thomas Gleixner [off-list ref] wrote:
quoted
quoted
which implies to me that spin_is_locked() will always return false.  Is this
expected behavior.
That's wrong. spin_is_locked should always return true on UP.
Surely it's not that simple?  Maybe spin_is_lock() should be undefined on UP.
That would lead to a lot of

#ifdef CONFIG_SMP

#endif

in drivers because there is driver code that uses spin_is_locked() in
fairly sensible fashion when dealing with locking.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help