On Mon, Aug 03, 2009 at 07:21:22PM -0700, David Brownell wrote:

On Wednesday 29 July 2009, Ben Dooks wrote:

quoted

quoted

 struct spi_driver {
+     const struct spi_device_id *id_table;
+     int                     (*probe_id)(struct spi_device *spi,
+                                         const struct spi_device_id *id);

how about leaving it at just probe and have either a call or a field
in the device that you can look at to see if this was a new style of
call?

quoted

      int                     (*probe)(struct spi_device *spi);

For the record, if this is going to happen I think the
appropriate long-term solution is to have probe() take
the device_id just as it does with other busses.

Just curious. Why you prefer another argument in the probe()
instead of calling some helper function? Most drivers don't
need the "id" argument, so why spend memory and cpu cycles
for it?

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2