Thread (15 messages) 15 messages, 5 authors, 2009-07-02

Re: [PATCH] alsa/soc: add locking to mpc5200-psc-ac97 driver

From: Jon Smirl <hidden>
Date: 2009-07-01 00:12:33
Also in: alsa-devel

On Tue, Jun 30, 2009 at 12:50 PM, Grant Likely[off-list ref] w=
rote:
On Tue, Jun 30, 2009 at 12:18 AM, Wolfram Sang[off-list ref] wro=
te:
quoted
quoted
+
+ =A0 =A0 /* Force clear the data valid bit */
+ =A0 =A0 in_be32(&psc_dma->psc_regs->ac97_data);
+
No mutex involved here. I think this is either a separate patch or it ne=
eds at
quoted
least to be mentioned in the patch description.
Oops, that was sloppy. =A0Yes, I'll put this into a separate patch. =A0Th=
anks.

Now that you have added the mutexes, do you ever need to force clear
the valid bit?
Maybe log an error if this happens so that we can track down why.

--=20
Jon Smirl
jonsmirl@gmail.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help