On Thu, Jun 18, 2009 at 8:26 AM, Wolfram Sang[off-list ref] wrote:

quoted

There used to be a sysfs interface for dumping these, but it was an
ugly misuse. =A0I'd like to leave these in. =A0I still have the sysfs bi=

ts

quoted

in a private patch and I'm going to rework them for debugfs.

Okay. Maybe a comment stating the future use will be nice.

okay

quoted

quoted

But I wonder more about the usage of the SS pin and if this chipsel is=

 needed

quoted

quoted

at all (sadly I cannot test as I don't have any board with SPI connect=

ed to

quoted

quoted

that device). You define the SS-pin as output, but do not set the SSOE=

-bit.

quoted

quoted

More, you use the MODF-feature, so the SS-pin should be defined as inp=

ut?

quoted

quoted

According to Table 17.3 in the PM, you have that pin defined as generi=

c purpose

quoted

quoted

output.

That's right. =A0The SS handling by the SPI device is completely
useless, so this driver uses it as a GPIO and asserts it manually.

That definately needs a comment :D (perhaps with some more details if you=

 know them).

quoted

The MODF irq is probably irrelevant, but I'd like to leave it in for
completeness.

But it won't work if the pin is set to output, no?

yes

Are you sure there are no side-effects?

I'm sure.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.