Thread (8 messages) 8 messages, 2 authors, 2009-06-27

Re: [PATCH 0/4 for 2.6.31] NET: Revive fixed link support

From: Grant Likely <hidden>
Date: 2009-06-26 23:35:47
Also in: netdev

On Fri, Jun 26, 2009 at 4:29 PM, Anton
Vorontsov[off-list ref] wrote:
Hi all,

The fixed link support is broken since The Big OF MDIO Rework,
the rework simply removed most of the code that was needed for
fixed links.

Too bad I didn't notice this earlier, I saw a bunch of patches
on the ml, but unfortunately I didn't look very close presuming
that Grant knew what he was doing. :-) And obviously I didn't
test linux-next on anything that requires a fixed link.
Apparently I didn't.  sorry.
Anyway, here are four patches. The first one adds the fixed link
support to a framework, otherwise we'd duplicate the code across
the drivers (as we did previously), and I tried to keep drivers'
changes minimal.
As I described in my previous email, I don't think this is a good
approach and I don't think it should be merged.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help