On Thursday 25 June 2009, Steven A. Falco wrote:

+       if (spi->mode & ~MODEBITS) {
+               dev_dbg(&spi->dev, "setup: unsupported mode bits %x\n",
+                       spi->mode & ~MODEBITS);
+               return -EINVAL;
+       }

This wasn't tested against 2.6.30-rc1 was it?

See the recent fixup patch I sent.  There's a spi_master->modebits
mask that should have been initialized, and which eliminates the
need for tests like that ...

+       dev_dbg(&spi->dev, "%s: mode %d, %u bpw, %d hz\n",
+               __func__, spi->mode, spi->bits_per_word,
+               spi->max_speed_hz);
+

... also the SPI core now provides a *standard* format debug
message for that stuff.  It also handles one more thing, which
I expect to see fixed in a v8 of this patch ... :)

- Dave