Re: [PATCH] powerpc/mpic: Fix mapping of "DCR" based MPIC variants
From: Akira Tsukamoto <hidden>
Date: 2009-06-24 05:35:02
Hi Benjamin, On Tue, 23 Jun 2009 12:47:59 +1000, Benjamin Herrenschmidt [off-list ref] mentioned:
Commit 31207dab7d2e63795eb15823947bd2f7025b08e2 "Fix incorrect allocation of interrupt rev-map" introduced a regression crashing on boot on machines using a "DCR" based MPIC, such as the Cell blades. The reason is that the irq host data structure is initialized much later as a result of that patch, causing our calls to mpic_map() do be done before we have a host setup. Unfortunately, this breaks _mpic_map_dcr() which uses the mpic->irqhost to get to the device node. This fixes it by, instead, passing the device node explicitely to mpic_map(). Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- arch/powerpc/sysdev/mpic.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-)
I confirmed that the boot failure on IBM Cell Blades QS21/22 are fixed with this patch. Acked-by: Akira Tsukamoto <redacted> -- Akira Tsukamoto Sony Computer Entertainment Inc. Architecture Lab. Japan