Re: [PATCH 31/33] ps3: Replace direct file operations by callback

From
Geoff Levand <hidden>
Date
2009-06-10 16:36:14
Reply to
Geert Uytterhoeven, 2009-06-10
On 06/10/2009 07:39 AM, Geert Uytterhoeven wrote:
Currently the FLASH database is updated by the kernel using file operations,
meant for userspace only. While this works for us because copy_{from,to}_user()
on powerpc can handle kernel pointers, this is unportable and a bad example.
Replace the file operations by callbacks, registered by the ps3flash driver.
Thanks for getting this one done.
Signed-off-by: Geert Uytterhoeven <redacted>
Cc: Geoff Levand <redacted>
---
 arch/powerpc/include/asm/ps3.h       |    7 ++
 arch/powerpc/platforms/ps3/os-area.c |  138 ++++++++++++++++++---------------
 drivers/char/ps3flash.c              |   94 +++++++++++++++++------
 3 files changed, 152 insertions(+), 87 deletions(-)
Acked-by: Geoff Levand <redacted>
Thread (60 messages) 60 messages, 8 authors, last reply 2009-07-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help