Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg
From: Ben Dooks <ben-linux@fluff.org>
Date: 2009-06-02 22:25:41
Also in:
linux-i2c
From: Ben Dooks <ben-linux@fluff.org>
Date: 2009-06-02 22:25:41
Also in:
linux-i2c
On Thu, May 28, 2009 at 10:15:22PM +0200, Esben Haabendal wrote:
On Thu, May 28, 2009 at 9:31 PM, Grant Likely [off-list ref] wrote:quoted
On Tue, May 26, 2009 at 5:30 AM, Esben Haabendal wrote:quoted
On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal wrote:quoted
This fixes MAL (arbitration lost) bug caused by illegal use of RSTA (repeated START) after STOP condition generated after last byte of reads. With this patch, it is possible to do an i2c_transfer() with additional i2c_msg's following the I2C_M_RD messages. It still needs to be resolved if it is possible to fix this issue by removing the STOP condition after reads in a robust way. Signed-off-by: Esben Haabendal <redacted> --- ?drivers/i2c/busses/i2c-mpc.c | ? ?9 +++++++-- ?1 files changed, 7 insertions(+), 2 deletions(-)Any blockers to get this accepted?It helps if you cc: developers/maintainers of the device. ?ie. Kumar for mpc8xxx, me for 52xx. This is the first time I noticed your posting. ?It will take me a few days before I get a chance to review it.Kumar, will you take a look at this patch?
is anyone else likely to review it, or should I merge? -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes'