Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o]
From: Grant Likely <hidden>
Date: 2009-06-17 17:30:30
Also in:
linux-next, lkml, netdev
On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell[off-list ref] wro= te:
On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell <sfr@canb.auug.org.au= wrote:quoted
Hi Kumar, On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala <galak@kernel.crashing.org=wrote:quoted
quoted
I'm confused by the proposed fix as we already have *mdio & *ph defined in this function:Which tree are you looking at? =A0Linus' tree, and linux-next, do not ha=
ve
quoted
those local variables ...Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework ucc_geth driver to use of_mdio infrastructure") removed the locals along with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses without adding the variables back. Here is the patch again: From: Subrata Modak <redacted> Subject: [PATCH] Fix build error in ucc_geth.c Fix the following build error: drivers/net/ucc_geth.c: In function bucc_geth_probeb: drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this fu=
nction)
drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is report=
ed only once
drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this =
function)
quoted hunk ↗ jump to hunk
make[2]: *** [drivers/net/ucc_geth.o] Error 1 Signed-off-by: Subrata Modak <redacted>--- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig =A0 =A0 =A0 =A02009-06-1=
0 11:58:39.000000000 -0500
quoted hunk ↗ jump to hunk
+++ linux-2.6.30-rc8/drivers/net/ucc_geth.c =A0 =A0 2009-06-10 22:28:13.0=
00000000 -0500
quoted hunk ↗ jump to hunk
@@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g=A0static int ucc_geth_probe(struct of_device* ofdev, const struct of_dev=
ice_id *match)
=A0{
+ =A0 =A0 =A0 struct device_node *mdio;
+ =A0 =A0 =A0 const phandle *ph;
=A0 =A0 =A0 =A0struct device *device =3D &ofdev->dev;
=A0 =A0 =A0 =A0struct device_node *np =3D ofdev->node;
=A0 =A0 =A0 =A0struct net_device *dev =3D NULL;Ah, this might not be the right fix then. I'll look. g. --=20 Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd.