Thread (2 messages) flat view 2 messages, 2 authors, 2009-05-21

Re: [PATCH] powerpc:beyond ARRAY_SIZE of args.args

From: Paul Mackerras <hidden>
Date: 2009-05-21 23:10:44

Roel Kluin writes:
Do not go beyond ARRAY_SIZE of args.args

Signed-off-by: Roel Kluin <redacted>
---
I'm quite sure the first is correct, but should maybe `args.nret'
and `nargs + args.nret' also be `>= ARRAY_SIZE(args.args)'?
I don't think this change is needed, and it changes a user-visible
API, so I'm nacking it unless you can convince me there's really a
problem.

If nargs == ARRAY_SIZE(args.args), then args.nret must be zero, so
nothing will access *(args.rets).

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help