Re: [PATCH v4 3/3] powerpc/virtex: Add Xilinx ML510 reference designsupport

On Thu, May 21, 2009 at 10:50 AM, Stephen Neuendorffer
[off-list ref] wrote:

quoted

diff --git a/arch/powerpc/platforms/44x/Kconfig

b/arch/powerpc/platforms/44x/Kconfig

quoted

index 0d83a6a..af1c51d 100644

--- a/arch/powerpc/platforms/44x/Kconfig
+++ b/arch/powerpc/platforms/44x/Kconfig

@@ -156,7 +156,7 @@ config YOSEMITE

=A0# =A0 =A0 =A0This option enables support for the IBM PPC440GX evaluat=

ion

board.

quoted

=A0config XILINX_VIRTEX440_GENERIC_BOARD
- =A0 =A0 bool "Generic Xilinx Virtex 440 board"
+ =A0 =A0 bool "Xilinx Virtex 5 support"

'Virtex 5' is a little ambiguous.. =A0I'd suggest keeping the old wording=

,

or saying 'Virtex 5 FXT support'. =A0Even then it's somewhat ambiguous,
since you could conceivably run linux on microblaze on V5FXT and use the
powerpc for something else..

Considering that this option only appears when AMCC 44x is selected, I
think the ambiguity is minimal.  :-)
I'll add the FXT though.

quoted

diff --git a/arch/powerpc/platforms/44x/virtex_ml510.c

b/arch/powerpc/platforms/44x/virtex_ml510.c

quoted

new file mode 100644
index 0000000..ba4a6e3

--- /dev/null
+++ b/arch/powerpc/platforms/44x/virtex_ml510.c

@@ -0,0 +1,29 @@
+#include <asm/i8259.h>
+#include <linux/pci.h>
+#include "44x.h"
+
+/**
+ * ml510_ail_quirk

Tpyo, but is the comment even necessary if it doesn't say anything
useful?

Oops; I started writing a comment and then never completed it.
Roderick; care to contribute some lines as to the purpose of this
block?

quoted

diff --git a/arch/powerpc/sysdev/xilinx_intc.c

b/arch/powerpc/sysdev/xilinx_intc.c

quoted

index 90b5772..3ee1fd3 100644

--- a/arch/powerpc/sysdev/xilinx_intc.c
+++ b/arch/powerpc/sysdev/xilinx_intc.c

@@ -257,6 +257,11 @@ static void __init

xilinx_i8259_setup_cascade(void)

quoted

=A0 =A0 =A0 i8259_init(cascade_node, 0);
=A0 =A0 =A0 set_irq_chained_handler(cascade_irq, xilinx_i8259_cascade);

+ =A0 =A0 /* Program irq 7 (usb/audio), 14/15 (ide) to level sensitive *=

/

quoted

+ =A0 =A0 /* This looks like a dirty hack to me --gcl */
+ =A0 =A0 outb(0xc0, 0x4d0);
+ =A0 =A0 outb(0xc0, 0x4d1);
+

Yeow... I agree about the dirty hack part... =A0shouldn't this be in the
device tree somewhere, or in the ali driver?

Chatting with Roderick on IRC today, it may be that these two lines
aren't even necessary.  They come from an old guide for porting Linux
to the ml410 in the pre-arch/powerpc days.  Now that IRQ sense is
encoded into the device tree, this probably isn't needed.

I'm curious if this works on ml410 as well.. =A0(Yes, I know, does this
really matter much? =A0But there are still a bunch of them floating aroun=

d

in universities.)

It should do (at least I hope it does).  If I get my hands on an
ML410, then I'll try it out.

=A0It may be nice to factor this out so ml410/ppc405 and
microblaze can get it as well.

indeed.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.