On Thu, 2009-04-16 at 11:06 +0530, Sachin Sant wrote:

Sachin Sant wrote:

quoted

Sachin Sant wrote:

quoted

Benjamin Herrenschmidt wrote:

quoted

On Tue, 2009-03-31 at 14:57 +0530, Sachin Sant wrote:
 

quoted

While executing CPU HotPlug[1] tests i observed that during
every cpu offline process an exception is thrown.
    

Looks like a BUG_ON() to me... can you look at what other
messages just before that ?  

Ben, seems like the following patch is causing the cpu hotplug
test failure.
[PATCH 6/6] powerpc/mm: Introduce early_init_mmu() on 64-bit

http://ozlabs.org/pipermail/linuxppc-dev/2009-March/069613.html

If i back out this patch, i am able to offline/online cpu's
without any issue.

I can recreate this problem with 2.6.30-rc2-git1 as well. Same BUG_ON while
running cpu hotplug tests.

Let me know if there is any thing i can help to find a fix for this.

Hi Sachin,

Does this patch, on top of Ben's patch, fix it?

cheers

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index db556d2..1ade7eb 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c

@@ -753,7 +753,7 @@ void __init early_init_mmu(void)
 }
 
 #ifdef CONFIG_SMP
-void __init early_init_mmu_secondary(void)
+void __cpuinit early_init_mmu_secondary(void)
 {
        /* Initialize hash table for that CPU */
        if (!firmware_has_feature(FW_FEATURE_LPAR))