Re: Porting the ibm_newemac driver to use phylib (and other PHY/MAC questions)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2009-04-27 00:11:49
Also in:
lkml, netdev
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2009-04-27 00:11:49
Also in:
lkml, netdev
On Mon, 2009-04-20 at 20:10 -0400, Kyle Moffett wrote:
quoted
IIRC, Ben had some issues with how phylib and the EMAC would need to interact. Not sure if he has those written down somewhere or not. (CC'd).Hmm, yeah, I'd be interested to see those. There's enough similar between phylib and the EMAC and sungem drivers that I'm considering a series of somewhat-mechanical patches to make EMAC and sungem use the "struct phy_device" and "struct mii_bus" from phylib, possibly abstracting out some helper functions along the way.
Yup, emac and sungem predate phylib. I had a quick look at what it would take to port at least emac over, the main issue was that I want to be able to sleep (ie, take a mutex) in my mdio read/write functions, and back then, phylib wouldn't let me do that due to spinlock and timer/softirq usage. Ben.