Re: powerpc/85xx: Add support for the "socrates" board (MPC8544)

On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger [off-list ref] wr=
ote:

Grant Likely wrote:

quoted

I agree 100% with David's comments, and I have some additional ones belo=

w.

quoted

On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger [off-list ref]=

 wrote:

quoted

quoted

+ =A0 =A0 =A0 soc8544@e0000000 {
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 #address-cells =3D <1>;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 #size-cells =3D <1>;
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 device_type =3D "soc";

Drop device_type here too.

Grrr, I just realized that removing the devices type "soc" has broken
fsl_get_sys_freq(). See:

http://lxr.linux.no/linux+v2.6.29/arch/powerpc/sysdev/fsl_soc.c#L80

We need a quick fix and we could take the occasion to establish a common
function for the MPC52xx as well, but it's not obvious to me how to find
the SOC node without the device type property.

SoC node should have a compatible property, just like everything else.

compatible =3D "fsl,mpc8544-immr";  (immr =3D=3D Internally Memory Mapped R=
egisters)

Many other boards already do this.

g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.