Re: [PATCH 1/2] powerpc/86xx: Board support for GE Fanuc's PPC9A

On Fri, Mar 13, 2009 at 03:52:26PM +0000, Martyn Welch wrote:

Support for the PPC9A VME Single Board Computer from GE Fanuc (PowerPC
MPC8641D).

This is the basic board support for GE Fanuc's PPC9A, a 6U single board
computer, based on Freescale's MPC8641D.

Signed-off-by: Martyn Welch <redacted>

[snip]

+	soc@fef00000 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		#interrupt-cells = <2>;
+		device_type = "soc";
+		compatible = "simple-bus";

There should be more detail in the compatible field - list the
specific model of the SoC, before including "simple-bus".  device_type
also doesn't really belong here, but it's possible you have to include
it for compatibility with older u-boot versions.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson